This repository was archived by the owner on Mar 4, 2024. It is now read-only.
glib: glib-macros: add SharedType and Shared derive macro#452
Merged
Conversation
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
left a comment
sdroege
left a comment
Member
There was a problem hiding this comment.
Looks nice apart from that, thanks! :)
mbiggio
force-pushed
the
wip/biggio/shared-macro
branch
from
36e0256 to
5e4a39e
Compare
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
reviewed
Apr 14, 2021
sdroege
left a comment
sdroege
left a comment
Member
There was a problem hiding this comment.
Apart from the open comments this seems ready to me now
mbiggio
force-pushed
the
wip/biggio/shared-macro
branch
from
5e4a39e to
1bb1375
Compare
sdroege
reviewed
Apr 15, 2021
mbiggio
force-pushed
the
wip/biggio/shared-macro
branch
from
1bb1375 to
d80d888
Compare
Member
|
Let me know when the above discussions are all resolved and this is ready for a final review :) |
mbiggio
force-pushed
the
wip/biggio/shared-macro
branch
from
d80d888 to
b9f423a
Compare
Member
|
@GuillaumeGomez @bilelmoussaoui What do you think? |
sdroege
approved these changes
Apr 15, 2021
sdroege
reviewed
Apr 15, 2021
sdroege
reviewed
Apr 15, 2021
sdroege
reviewed
Apr 15, 2021
sdroege
approved these changes
Apr 15, 2021
Contributor
|
Should |
Member
That would make sense, good point! |
added 3 commits
April 16, 2021 10:40
Added a SharedType trait that allows implementing reference-counted types in terms os std::sync::Arc. In particular, the ffi methods that increment reference counting can return always the same pointer value. Also, added a `Shared` derive macro, similar to the existing `GBoxed` one, that simplifies the creation of Shared objects.
mbiggio
force-pushed
the
wip/biggio/shared-macro
branch
from
a282058 to
3c24a50
Compare
bilelmoussaoui
approved these changes
Apr 16, 2021
bilelmoussaoui
left a comment
bilelmoussaoui
left a comment
Member
There was a problem hiding this comment.
Looks good to me, the name still seems a bit weird. Although, I don't think we can do any better if we want to keep the Boxed reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a SharedType trait that allows implementing reference-counted
types in terms os std::sync::Arc. In particular, the ffi methods that
increment reference counting can return always the same pointer value.
Also, added a
Sharedderive macro, similar to the existingGBoxedone, that simplifies the creation of Shared objects.